Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1405993006: Revert of Change shortcut install location to non-subdir. (Closed)

Created:
5 years, 1 month ago by gab
Modified:
5 years, 1 month ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change shortcut install location to non-subdir. (patchset #23 id:440001 of https://codereview.chromium.org/1289333005/ ) Reason for revert: Cause of http://crbug.com/548965 and http://crbug.com/548964, need to figure out what's going on there before this goes to a larger population. Only Canary was affected for now and users can recover through uninstall/reinstall (or even potentially just reboot if it's a Windows shell caching issue). Original issue's description: > Change shortcut install location to non-subdir. > > BUG=169669 > > Committed: https://crrev.com/c5bab94fdde60b2bc9ed93822f35c5ce50202d26 > Cr-Commit-Position: refs/heads/master@{#356371} TBR=grt@chromium.org,jhawkins@chromium.org,benwells@chromium.org,bcwhite@chromium.org BUG=169669, 548965, 548964 Committed: https://crrev.com/3ac10b06845551615dd9332ea040c5f589790644 Cr-Commit-Position: refs/heads/master@{#357038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -249 lines) Patch
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 4 chunks +7 lines, -77 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util.h View 6 chunks +10 lines, -18 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 16 chunks +29 lines, -55 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 8 chunks +25 lines, -68 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gab
Created Revert of Change shortcut install location to non-subdir.
5 years, 1 month ago (2015-10-30 02:23:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405993006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405993006/1
5 years, 1 month ago (2015-10-30 02:24:41 UTC) #4
bcwhite
lgtm
5 years, 1 month ago (2015-10-30 02:26:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 03:26:20 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 03:27:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ac10b06845551615dd9332ea040c5f589790644
Cr-Commit-Position: refs/heads/master@{#357038}

Powered by Google App Engine
This is Rietveld 408576698