Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: chrome/installer/setup/setup_main.cc

Issue 1405993006: Revert of Change shortcut install location to non-subdir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/setup/install_unittest.cc ('k') | chrome/installer/util/shell_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/setup/setup_main.h" 5 #include "chrome/installer/setup/setup_main.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <msi.h> 8 #include <msi.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #include <shlobj.h> 10 #include <shlobj.h>
(...skipping 974 matching lines...) Expand 10 before | Expand all | Expand 10 after
985 if (base::PathExists(chrome_exe)) { 985 if (base::PathExists(chrome_exe)) {
986 Product chrome(chrome_dist); 986 Product chrome(chrome_dist);
987 987
988 // Create the Start menu shortcut and pin it to the Win7+ taskbar. 988 // Create the Start menu shortcut and pin it to the Win7+ taskbar.
989 ShellUtil::ShortcutProperties shortcut_properties(ShellUtil::CURRENT_USER); 989 ShellUtil::ShortcutProperties shortcut_properties(ShellUtil::CURRENT_USER);
990 chrome.AddDefaultShortcutProperties(chrome_exe, &shortcut_properties); 990 chrome.AddDefaultShortcutProperties(chrome_exe, &shortcut_properties);
991 if (InstallUtil::ShouldInstallMetroProperties()) 991 if (InstallUtil::ShouldInstallMetroProperties())
992 shortcut_properties.set_dual_mode(true); 992 shortcut_properties.set_dual_mode(true);
993 shortcut_properties.set_pin_to_taskbar(true); 993 shortcut_properties.set_pin_to_taskbar(true);
994 ShellUtil::CreateOrUpdateShortcut( 994 ShellUtil::CreateOrUpdateShortcut(
995 ShellUtil::SHORTCUT_LOCATION_START_MENU_ROOT, chrome_dist, 995 ShellUtil::SHORTCUT_LOCATION_START_MENU_CHROME_DIR, chrome_dist,
996 shortcut_properties, ShellUtil::SHELL_SHORTCUT_CREATE_ALWAYS); 996 shortcut_properties, ShellUtil::SHELL_SHORTCUT_CREATE_ALWAYS);
997 997
998 // Register Chrome at user-level and make it default. 998 // Register Chrome at user-level and make it default.
999 scoped_ptr<WorkItemList> delegate_execute_list( 999 scoped_ptr<WorkItemList> delegate_execute_list(
1000 WorkItem::CreateWorkItemList()); 1000 WorkItem::CreateWorkItemList());
1001 installer::AddDelegateExecuteWorkItems( 1001 installer::AddDelegateExecuteWorkItems(
1002 installer_state, chrome_exe.DirName(), Version(), chrome, 1002 installer_state, chrome_exe.DirName(), Version(), chrome,
1003 delegate_execute_list.get()); 1003 delegate_execute_list.get());
1004 delegate_execute_list->Do(); 1004 delegate_execute_list->Do();
1005 if (ShellUtil::CanMakeChromeDefaultUnattended()) { 1005 if (ShellUtil::CanMakeChromeDefaultUnattended()) {
(...skipping 875 matching lines...) Expand 10 before | Expand all | Expand 10 after
1881 // Note that we allow the status installer::UNINSTALL_REQUIRES_REBOOT 1881 // Note that we allow the status installer::UNINSTALL_REQUIRES_REBOOT
1882 // to pass through, since this is only returned on uninstall which is 1882 // to pass through, since this is only returned on uninstall which is
1883 // never invoked directly by Google Update. 1883 // never invoked directly by Google Update.
1884 return_code = InstallUtil::GetInstallReturnCode(install_status); 1884 return_code = InstallUtil::GetInstallReturnCode(install_status);
1885 } 1885 }
1886 1886
1887 VLOG(1) << "Installation complete, returning: " << return_code; 1887 VLOG(1) << "Installation complete, returning: " << return_code;
1888 1888
1889 return return_code; 1889 return return_code;
1890 } 1890 }
OLDNEW
« no previous file with comments | « chrome/installer/setup/install_unittest.cc ('k') | chrome/installer/util/shell_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698