Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Issue 1405793002: Move legacy webkit properties into CSSPropertyParser (Closed)

Created:
5 years, 2 months ago by rwlbuis
Modified:
5 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move legacy webkit properties into CSSPropertyParser Move legacy webkit related properties from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/31cac25752d71e57922d1f17a0e819faea3585a4 Cr-Commit-Position: refs/heads/master@{#354609}

Patch Set 1 #

Patch Set 2 : Clean up a bit #

Total comments: 2

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 2 chunks +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 2 chunks +4 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rwlbuis
PTAL
5 years, 2 months ago (2015-10-15 22:13:05 UTC) #2
Timothy Loh
lgtm, but it's probably a good idea to list the properties you're moving in the ...
5 years, 2 months ago (2015-10-15 23:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405793002/40001
5 years, 2 months ago (2015-10-16 20:09:06 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-16 21:41:16 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 21:41:57 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/31cac25752d71e57922d1f17a0e819faea3585a4
Cr-Commit-Position: refs/heads/master@{#354609}

Powered by Google App Engine
This is Rietveld 408576698