Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1405793002: Move legacy webkit properties into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch for landing Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
index 78094f5f6c33dcea4836ec7e065b2ed1060fe94a..47bfb0fb1a58b13e2901ec0357b819e32bd1c5f5 100644
--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
@@ -1084,30 +1084,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
break;
// End of CSS3 properties
- // Apple specific properties. These will never be standardized and are purely to
- // support custom WebKit-based Apple applications.
- case CSSPropertyWebkitLineClamp:
- // When specifying number of lines, don't allow 0 as a valid value
- // When specifying either type of unit, require non-negative integers
- validPrimitive = (!id && !isCalculation(value) && validUnit(value, FInteger | FPercent | FNonNeg) && (value->unit() == CSSPrimitiveValue::UnitType::Percentage || value->fValue));
- break;
-
- case CSSPropertyWebkitFontSizeDelta: // <length>
- validPrimitive = validUnit(value, FLength | FUnitlessQuirk);
- break;
-
- case CSSPropertyWebkitHyphenateCharacter:
- case CSSPropertyWebkitLocale:
- if (id == CSSValueAuto) {
- validPrimitive = true;
- } else if (value->m_unit == CSSParserValue::String) {
- parsedValue = createPrimitiveStringValue(value);
- m_valueList->next();
- }
- break;
-
- // End Apple-specific properties
-
case CSSPropertyWebkitAppRegion:
if (id >= CSSValueDrag && id <= CSSValueNoDrag)
validPrimitive = true;
@@ -1299,6 +1275,10 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyWebkitLogicalHeight:
case CSSPropertyClip:
case CSSPropertyTouchAction:
+ case CSSPropertyWebkitLineClamp:
+ case CSSPropertyWebkitFontSizeDelta:
+ case CSSPropertyWebkitHyphenateCharacter:
+ case CSSPropertyWebkitLocale:
validPrimitive = false;
break;
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698