Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 14057012: Revert 148647 "Remove frame flattening support as Chromium has n..." (Closed)

Created:
7 years, 8 months ago by apavlov
Modified:
7 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews
Visibility:
Public.

Description

Revert 148647 "Remove frame flattening support as Chromium has n..." Lots of tests have started failing on all bots. > Remove frame flattening support as Chromium has no intention of using it > > Chromium does not use the frame flattening code on any platform, though it used > to use it for frameset flattening on Android, but that is no longer the case. > > As there is no intention of ever using it, it should be removed. > > Committed on behalf of Kenneth Rohde Christiansen <kenneth.r.christiansen@intel.com>;. > > BUG=231898 > > Review URL: https://codereview.chromium.org/13963006 TBR=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -31 lines) Patch
M trunk/LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 0 comments Download
A + trunk/LayoutTests/fast/spatial-navigation/snav-iframe-flattening-simple.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/LayoutTests/fast/spatial-navigation/snav-iframe-flattening-simple-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/LayoutTests/fast/text-autosizing/narrow-iframe-flattened.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/LayoutTests/fast/text-autosizing/narrow-iframe-flattened-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/LayoutTests/http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/LayoutTests/http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/LayoutTests/plugins/frameset-with-plugin-frame.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/LayoutTests/plugins/frameset-with-plugin-frame-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/Source/WebKit/chromium/public/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/WebKit/chromium/src/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/Source/core/page/FrameView.h View 3 chunks +6 lines, -0 lines 0 comments Download
M trunk/Source/core/page/FrameView.cpp View 10 chunks +96 lines, -19 lines 0 comments Download
M trunk/Source/core/page/Settings.in View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/core/platform/ScrollView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/Source/core/platform/ScrollView.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M trunk/Source/core/rendering/RenderFrame.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/rendering/RenderFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/Source/core/rendering/RenderFrameBase.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/core/rendering/RenderFrameBase.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/Source/core/rendering/RenderFrameSet.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/Source/core/rendering/RenderFrameSet.cpp View 3 chunks +120 lines, -1 line 0 comments Download
M trunk/Source/core/rendering/RenderIFrame.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/Source/core/rendering/RenderIFrame.cpp View 6 chunks +37 lines, -5 lines 0 comments Download
M trunk/Source/core/rendering/RenderPart.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/rendering/TextAutosizer.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
apavlov
7 years, 8 months ago (2013-04-18 14:01:34 UTC) #1
apavlov
Committed patchset #1 manually as r148649.
7 years, 8 months ago (2013-04-18 14:02:28 UTC) #2
ojan
7 years, 8 months ago (2013-04-18 20:53:04 UTC) #3
Message was sent while issue was closed.
On 2013/04/18 14:02:28, apavlov wrote:
> Committed patchset #1 manually as r148649.

Link to a build that failed:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/9079

Please include more data in the revert message so that it's easy for the patch
author to know exactly what failed.

Powered by Google App Engine
This is Rietveld 408576698