Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: trunk/Source/core/platform/ScrollView.cpp

Issue 14057012: Revert 148647 "Remove frame flattening support as Chromium has n..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/core/platform/ScrollView.h ('k') | trunk/Source/core/rendering/RenderFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/platform/ScrollView.cpp
===================================================================
--- trunk/Source/core/platform/ScrollView.cpp (revision 148648)
+++ trunk/Source/core/platform/ScrollView.cpp (working copy)
@@ -82,7 +82,7 @@
void ScrollView::setHasHorizontalScrollbar(bool hasBar)
{
- ASSERT(!hasBar);
+ ASSERT(!hasBar || !avoidScrollbarCreation());
if (hasBar && !m_horizontalScrollbar) {
m_horizontalScrollbar = createScrollbar(HorizontalScrollbar);
addChild(m_horizontalScrollbar.get());
@@ -93,14 +93,14 @@
removeChild(m_horizontalScrollbar.get());
m_horizontalScrollbar = 0;
}
-
+
if (AXObjectCache* cache = axObjectCache())
cache->handleScrollbarUpdate(this);
}
void ScrollView::setHasVerticalScrollbar(bool hasBar)
{
- ASSERT(!hasBar);
+ ASSERT(!hasBar || !avoidScrollbarCreation());
if (hasBar && !m_verticalScrollbar) {
m_verticalScrollbar = createScrollbar(VerticalScrollbar);
addChild(m_verticalScrollbar.get());
@@ -425,13 +425,13 @@
newHasVerticalScrollbar = (vScroll == ScrollbarAlwaysOn);
if (m_scrollbarsSuppressed || (hScroll != ScrollbarAuto && vScroll != ScrollbarAuto)) {
- if (hasHorizontalScrollbar != newHasHorizontalScrollbar && hasHorizontalScrollbar)
+ if (hasHorizontalScrollbar != newHasHorizontalScrollbar && (hasHorizontalScrollbar || !avoidScrollbarCreation()))
setHasHorizontalScrollbar(newHasHorizontalScrollbar);
- if (hasVerticalScrollbar != newHasVerticalScrollbar && hasVerticalScrollbar)
+ if (hasVerticalScrollbar != newHasVerticalScrollbar && (hasVerticalScrollbar || !avoidScrollbarCreation()))
setHasVerticalScrollbar(newHasVerticalScrollbar);
} else {
bool sendContentResizedNotification = false;
-
+
IntSize docSize = totalContentsSize();
IntSize fullVisibleSize = visibleContentRect(IncludeScrollbars).size();
@@ -454,7 +454,7 @@
newHasHorizontalScrollbar = false;
bool scrollbarIsOverlay = ScrollbarTheme::theme()->usesOverlayScrollbars();
- if (hasHorizontalScrollbar != newHasHorizontalScrollbar && hasHorizontalScrollbar) {
+ if (hasHorizontalScrollbar != newHasHorizontalScrollbar && (hasHorizontalScrollbar || !avoidScrollbarCreation())) {
if (!scrollbarIsOverlay)
sendContentResizedNotification = true;
if (scrollOrigin().y() && !newHasHorizontalScrollbar && !scrollbarIsOverlay)
@@ -464,7 +464,7 @@
setHasHorizontalScrollbar(newHasHorizontalScrollbar);
}
- if (hasVerticalScrollbar != newHasVerticalScrollbar && hasVerticalScrollbar) {
+ if (hasVerticalScrollbar != newHasVerticalScrollbar && (hasVerticalScrollbar || !avoidScrollbarCreation())) {
if (!scrollbarIsOverlay)
sendContentResizedNotification = true;
if (scrollOrigin().x() && !newHasVerticalScrollbar && !scrollbarIsOverlay)
« no previous file with comments | « trunk/Source/core/platform/ScrollView.h ('k') | trunk/Source/core/rendering/RenderFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698