sdk/lib/io/websocket_impl.dart - Issue 14057010: Re-write _BufferList to keep an internal Uint8List buffer, that will grow on demand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/websocket_impl.dart

Issue 14057010: Re-write _BufferList to keep an internal Uint8List buffer, that will grow on demand. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix comment Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/io/websocket_impl.dart

diff --git a/sdk/lib/io/websocket_impl.dart b/sdk/lib/io/websocket_impl.dart

index a1a2308086c6b1285640cad870da482bcca5a002..52587ed0306ac45ac6785fc993e6dd343bbc512b 100644

--- a/sdk/lib/io/websocket_impl.dart

+++ b/sdk/lib/io/websocket_impl.dart

@@ -277,11 +277,7 @@ class _WebSocketProtocolTransformer extends StreamEventTransformer {

sink.add(_buffer.toString());

break;

case _WebSocketMessageType.BINARY:

- if (_buffer.length == 0) {

- sink.add(const []);

- } else {

- sink.add(_buffer.readBytes(_buffer.length));

- }

+ sink.add(_buffer.readBytes());

break;

}

_buffer = null;

« no previous file with comments | « sdk/lib/io/file_impl.dart ('k') | no next file » | no next file with comments »