sdk/lib/io/file_impl.dart - Issue 14057010: Re-write _BufferList to keep an internal Uint8List buffer, that will grow on demand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/file_impl.dart

Issue 14057010: Re-write _BufferList to keep an internal Uint8List buffer, that will grow on demand. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix comment Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/io/file_impl.dart

diff --git a/sdk/lib/io/file_impl.dart b/sdk/lib/io/file_impl.dart

index a5ae2f509d03cc92bb8d5f8961150650cdf24d82..ef467ac5577b40c05aab9fa7709fb07cfda4c0b2 100644

--- a/sdk/lib/io/file_impl.dart

+++ b/sdk/lib/io/file_impl.dart

@@ -478,8 +478,7 @@ class _File extends _FileBase implements File {

openRead().listen(

(d) => chunks.add(d),

onDone: () {

- var result = chunks.readBytes(chunks.length);

- if (result == null) result = <int>[];

+ var result = chunks.readBytes();

completer.complete(result);

onError: (e) {

« no previous file with comments | « sdk/lib/io/buffer_list.dart ('k') | sdk/lib/io/websocket_impl.dart » ('j') | no next file with comments »