Cleanup chrome/version.h handling

chrome/common/BUILD.gn

Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index e1f8f3a3939bc1fe698ae43e6f124680a418d565..97019946ded0b3feb11af9fb07f07db8d00bccde 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -36,7 +36,7 @@ if (enable_extensions) {
   }
 }
 
-# GYP version: chrome/chrome_common.gyp:common
+# GYP version: chrome/chrome_common.gypi:common
 static_library("common") {
   sources = rebase_path(gypi_values.chrome_common_sources, ".", "//chrome")
   defines = []
@@ -269,12 +269,20 @@ static_library("common") {
   }
 }
 
-process_version("make_chrome_version") {
-  template_file = "chrome_version.cc.version"
-  output = "$target_gen_dir/chrome_version.cc"
+# GYP version: chrome/common_constants.gyp:version_header
+process_version("version_header") {
+  # TODO(brettw) this should have more reduced visibility, but chrome/browser
+  # currently depends on this.
+  #visibility = [ ":*" ]
+
+  # This one just uses the custom template and no separate sources.
+  sources = []
+  template_file = "chrome_version.h.in"
+
+  output = "$target_gen_dir/chrome_version.h"
 }
 
-# GN version: chrome/common_constants.gyp:common_constants
+# GYP version: chrome/common_constants.gyp:common_constants
 static_library("constants") {
   sources = [
     "chrome_constants.cc",
@@ -303,7 +311,7 @@ static_library("constants") {
     "//content/public/common:result_codes",
   ]
   deps = [
-    ":make_chrome_version",
+    ":version_header",
     "//base",
     "//base/third_party/dynamic_annotations",
     "//components/bookmarks/common",