Cleanup chrome/version.h handling

chrome/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//tools/grit/grit_rule.gni")
 import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni")
 import("//chrome/version.gni")
 
 gypi_values = exec_script("//build/gypi_to_gn.py",
                           [ rebase_path("../chrome_common.gypi") ],
@@ skipping 18 matching lines @@
   grit("extensions_api_resources") {
     source = "extensions_api_resources.grd"
     output_dir = "$root_gen_dir/chrome"
     outputs = [
       "grit/extensions_api_resources.h",
       "extensions_api_resources.pak",
     ]
   }
 }
 
-# GYP version: chrome/chrome_common.gyp:common
+# GYP version: chrome/chrome_common.gypi:common
 static_library("common") {
   sources = rebase_path(gypi_values.chrome_common_sources, ".", "//chrome")
   defines = []
 
   configs += [
     "//build/config:precompiled_headers",
     "//build/config/compiler:wexit_time_destructors",
   ]
 
   public_deps = [
@@ skipping 212 matching lines @@
     public_deps += [ "//components/policy" ]
   }
 
   if (safe_browsing_mode == 1) {
     sources += rebase_path(gypi_values.chrome_common_full_safe_browsing_sources,
                            ".",
                            "//chrome")
   }
 }
 
-process_version("make_chrome_version") {
-  template_file = "chrome_version.cc.version"
-  output = "$target_gen_dir/chrome_version.cc"
+# GYP version: chrome/common_constants.gyp:version_header
+process_version("version_header") {
+  # TODO(brettw) this should have more reduced visibility, but chrome/browser
+  # currently depends on this.
+  #visibility = [ ":*" ]
+
+  # This one just uses the custom template and no separate sources.
+  sources = []
+  template_file = "chrome_version.h.in"
+
+  output = "$target_gen_dir/chrome_version.h"
 }
 
-# GN version: chrome/common_constants.gyp:common_constants
+# GYP version: chrome/common_constants.gyp:common_constants
 static_library("constants") {
   sources = [
     "chrome_constants.cc",
     "chrome_constants.h",
     "chrome_icon_resources_win.cc",
     "chrome_icon_resources_win.h",
     "chrome_paths.cc",
     "chrome_paths.h",
     "chrome_paths_android.cc",
     "chrome_paths_internal.h",
     "chrome_paths_linux.cc",
     "chrome_paths_mac.mm",
     "chrome_paths_win.cc",
     "chrome_result_codes.h",
     "chrome_switches.cc",
     "chrome_switches.h",
     "env_vars.cc",
     "env_vars.h",
     "pref_font_script_names-inl.h",
     "pref_font_webkit_names.h",
     "pref_names.cc",
     "pref_names.h",
   ]
 
   public_deps = [
     "//content/public/common:result_codes",
   ]
   deps = [
-    ":make_chrome_version",
+    ":version_header",
     "//base",
     "//base/third_party/dynamic_annotations",
     "//components/bookmarks/common",
     "//third_party/widevine/cdm:version_h",
   ]
 
   if (enable_nacl) {
     deps += [ "//components/nacl:nacl_switches" ]
   }
 
@@ skipping 56 matching lines @@
     ":constants",
     "//base",
   ]
 }
 
 mojom("mojo_bindings") {
   sources = [
     "resource_usage_reporter.mojom",
   ]
 }