Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: chrome/BUILD.gn

Issue 1405633002: Cleanup chrome/version.h handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Building Chrome is hard Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 67431e3775835f280482d62400e840394ac79c6a..4693d6c2c23c12361d6cdf5a9ab71c65a4ec65a0 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -425,22 +425,6 @@ group("child_dependencies") {
}
if (is_win) {
- # TODO(brettw) this duplicates "//chrome/common:version" which applies to
- # Linux.
- process_version("version_header") {
- # TODO(brettW) this should have more reduced visibility, but chrome/browser
- # currently depends on this.
- #visibility = [ ":*" ]
-
- # This one just uses the custom template and no separate sources.
- sources = []
- template_file = "version.h.in"
-
- # TODO(brettw) this should move to $target_gen_dir/version.h and
- # source files including it should reference it via "chrome/version.h"
- output = "$root_gen_dir/version.h"
- }
-
process_version("chrome_exe_version") {
template_file = chrome_version_rc_template
sources = [
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698