Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/BUILD.gn

Issue 1405633002: Cleanup chrome/version.h handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Building Chrome is hard Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/locales.gni") 7 import("//build/config/locales.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 import("//build/config/ui.gni") 9 import("//build/config/ui.gni")
10 import("//build/config/win/manifest.gni") 10 import("//build/config/win/manifest.gni")
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 if (cld_version == 2) { 418 if (cld_version == 2) {
419 public_deps += [ "//third_party/cld_2:cld2_platform_impl" ] 419 public_deps += [ "//third_party/cld_2:cld2_platform_impl" ]
420 } 420 }
421 421
422 if (enable_nacl) { 422 if (enable_nacl) {
423 public_deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ] 423 public_deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ]
424 } 424 }
425 } 425 }
426 426
427 if (is_win) { 427 if (is_win) {
428 # TODO(brettw) this duplicates "//chrome/common:version" which applies to
429 # Linux.
430 process_version("version_header") {
431 # TODO(brettW) this should have more reduced visibility, but chrome/browser
432 # currently depends on this.
433 #visibility = [ ":*" ]
434
435 # This one just uses the custom template and no separate sources.
436 sources = []
437 template_file = "version.h.in"
438
439 # TODO(brettw) this should move to $target_gen_dir/version.h and
440 # source files including it should reference it via "chrome/version.h"
441 output = "$root_gen_dir/version.h"
442 }
443
444 process_version("chrome_exe_version") { 428 process_version("chrome_exe_version") {
445 template_file = chrome_version_rc_template 429 template_file = chrome_version_rc_template
446 sources = [ 430 sources = [
447 "app/chrome_exe.ver", 431 "app/chrome_exe.ver",
448 ] 432 ]
449 output = "$target_gen_dir/chrome_exe_version.rc" 433 output = "$target_gen_dir/chrome_exe_version.rc"
450 } 434 }
451 435
452 process_version("chrome_dll_version") { 436 process_version("chrome_dll_version") {
453 template_file = chrome_version_rc_template 437 template_file = chrome_version_rc_template
(...skipping 563 matching lines...) Expand 10 before | Expand all | Expand 10 after
1017 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1001 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1018 "//chrome/tools/build/linux/chrome-wrapper", 1002 "//chrome/tools/build/linux/chrome-wrapper",
1019 "//third_party/xdg-utils/scripts/xdg-mime", 1003 "//third_party/xdg-utils/scripts/xdg-mime",
1020 "//third_party/xdg-utils/scripts/xdg-settings", 1004 "//third_party/xdg-utils/scripts/xdg-settings",
1021 ] 1005 ]
1022 outputs = [ 1006 outputs = [
1023 "$root_out_dir/{{source_file_part}}", 1007 "$root_out_dir/{{source_file_part}}",
1024 ] 1008 ]
1025 } 1009 }
1026 } 1010 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698