Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 1405513003: Revert of [Oilpan] Fix wrong usage of HeapCountedSet<EventTarget*> (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Oilpan] Fix wrong usage of HeapCountedSet<EventTarget*> (patchset #3 id:80001 of https://codereview.chromium.org/1401033002/ ) Reason for revert: Broke a number of tests on all Oilpan bots, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/builds/29326 Lazy sweeping of EventTargetSet related. Original issue's description: > Fix wrong usage of HeapCountedSet<EventTarget*> > > BUG=515524 > > Committed: https://crrev.com/0ab9a39b2347bc686cb6c2a7464acfebe3d4bd10 > Cr-Commit-Position: refs/heads/master@{#353714} TBR=oilpan-reviews@chromium.org,haraken@chromium.org,peria@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=515524 Committed: https://crrev.com/7261e3643f5e8fde78f93533b2d274f926a8bd8f Cr-Commit-Position: refs/heads/master@{#353756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Created Revert of [Oilpan] Fix wrong usage of HeapCountedSet<EventTarget*>
5 years, 2 months ago (2015-10-13 15:21:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405513003/1
5 years, 2 months ago (2015-10-13 15:21:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 15:28:09 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7261e3643f5e8fde78f93533b2d274f926a8bd8f Cr-Commit-Position: refs/heads/master@{#353756}
5 years, 2 months ago (2015-10-13 15:29:11 UTC) #4
haraken
Thanks, LGTM
5 years, 2 months ago (2015-10-13 15:42:18 UTC) #5
sof
On 2015/10/13 15:42:18, haraken wrote: > Thanks, LGTM it is inconsistent to introduce a transition ...
5 years, 2 months ago (2015-10-13 22:27:24 UTC) #6
haraken
On 2015/10/13 22:27:24, sof wrote: > On 2015/10/13 15:42:18, haraken wrote: > > Thanks, LGTM ...
5 years, 2 months ago (2015-10-13 23:20:21 UTC) #7
sof
On 2015/10/13 23:20:21, haraken wrote: > On 2015/10/13 22:27:24, sof wrote: > > On 2015/10/13 ...
5 years, 2 months ago (2015-10-14 06:20:21 UTC) #8
peria
5 years, 2 months ago (2015-10-14 07:13:08 UTC) #9
Message was sent while issue was closed.
On 2015/10/14 06:20:21, sof wrote:
> On 2015/10/13 23:20:21, haraken wrote:
> > On 2015/10/13 22:27:24, sof wrote:
> > > On 2015/10/13 15:42:18, haraken wrote:
> > > > Thanks, LGTM
> > > 
> > > it is inconsistent to introduce a transition type here. we don't do that
> > > elsewhere for these manually managed weak refs (cf.
> > > LocalFrame::m_pluginElements).
> > 
> > oh, I didn't know that. I'm fine with either way (use a raw pointer or use a
> > Member) as long as it's consistent through the code base.
> 
> The on-heap version also needs to trace the backing storage, which wasn't
done.
> I suggest keeping this type alias as-is. But with a suitable comment etc.

Thank you for this revert.

I think it good to include this change in
https://codereview.chromium.org/1397073002/
to keep them consistent.
What do you think?

Powered by Google App Engine
This is Rietveld 408576698