Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 1405383003: IsSecureTLSCipherSuite should not classify DHE_RSA as secure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index 6d9760fae40cb0c82c1d02fb90e0b32f3f7cc212..1be71144a3ba3e0fcd1e535dfafa5d03ea395477 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -1262,7 +1262,7 @@ SECStatus SSLClientSocketNSS::Core::CanFalseStartCallback(
SSL_GetChannelInfo(socket, &channel_info, sizeof(channel_info));
if (ok != SECSuccess || channel_info.length != sizeof(channel_info) ||
channel_info.protocolVersion < SSL_LIBRARY_VERSION_TLS_1_2 ||
- !IsFalseStartableTLSCipherSuite(channel_info.cipherSuite)) {
+ !IsSecureTLSCipherSuite(channel_info.cipherSuite)) {
*can_false_start = PR_FALSE;
return SECSuccess;
}

Powered by Google App Engine
This is Rietveld 408576698