Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket/ssl_client_socket.cc

Issue 1405383003: IsSecureTLSCipherSuite should not classify DHE_RSA as secure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_nss.cc » ('j') | net/ssl/ssl_cipher_suite_names_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket.cc
diff --git a/net/socket/ssl_client_socket.cc b/net/socket/ssl_client_socket.cc
index 3472fd023f2aae650c253a8212de8c533dbc5c55..e8ba9fa7939116436522d370874a55a004aa1c3b 100644
--- a/net/socket/ssl_client_socket.cc
+++ b/net/socket/ssl_client_socket.cc
@@ -175,7 +175,7 @@ bool SSLClientSocket::IsChannelIDEnabled(
bool SSLClientSocket::HasCipherAdequateForHTTP2(
const std::vector<uint16>& cipher_suites) {
for (uint16 cipher : cipher_suites) {
- if (IsSecureTLSCipherSuite(cipher))
+ if (IsTLSCipherSuiteAllowedByHTTP2(cipher))
return true;
}
return false;
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_nss.cc » ('j') | net/ssl/ssl_cipher_suite_names_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698