Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2364)

Unified Diff: chrome/browser/ui/webui/media/webrtc_logs_ui.cc

Issue 1405373002: Fix WebRTC log list errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated log uploader unit test. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media/webrtc_logs_ui.cc
diff --git a/chrome/browser/ui/webui/media/webrtc_logs_ui.cc b/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
index 37ab6fe51bbe42a3d425011c20c71c08df84d05d..9154a58fef2c129d876e92d4042212012503b2d1 100644
--- a/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
+++ b/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
@@ -149,18 +149,16 @@ void WebRtcLogsDOMHandler::UpdateUI() {
i != uploads.end();
++i) {
base::DictionaryValue* upload = new base::DictionaryValue();
Evan Stade 2015/10/16 16:37:20 can you make this a scoped_ptr
Henrik Grunell 2015/10/19 10:53:24 Done.
- upload->SetString("id", i->id);
+ upload->SetString("id", i->upload_id);
base::string16 value_w;
- if (!i->time.is_null())
- value_w = base::TimeFormatFriendlyDateAndTime(i->time);
+ if (!i->upload_time.is_null())
+ value_w = base::TimeFormatFriendlyDateAndTime(i->upload_time);
upload->SetString("upload_time", value_w);
value_w.clear();
- double seconds_since_epoch;
- if (base::StringToDouble(i->local_id, &seconds_since_epoch)) {
- base::Time capture_time = base::Time::FromDoubleT(seconds_since_epoch);
- value_w = base::TimeFormatFriendlyDateAndTime(capture_time);
+ if (!i->capture_time.is_null()) {
+ value_w = base::TimeFormatFriendlyDateAndTime(i->capture_time);
Evan Stade 2015/10/16 16:37:20 nit: no curlies
Henrik Grunell 2015/10/19 10:53:24 Done.
}
upload->SetString("capture_time", value_w);

Powered by Google App Engine
This is Rietveld 408576698