components/crash/core/browser/crashes_ui_util.cc - Issue 1405373002: Fix WebRTC log list errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/core/browser/crashes_ui_util.cc

Issue 1405373002: Fix WebRTC log list errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated log uploader unit test. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/crash/core/browser/crashes_ui_util.cc

diff --git a/components/crash/core/browser/crashes_ui_util.cc b/components/crash/core/browser/crashes_ui_util.cc

index bd74af6056f18b7f797b35010e16912541bb8acc..916f3aa5e5696ad5a1c1ff8858b601b42ae09209 100644

--- a/components/crash/core/browser/crashes_ui_util.cc

+++ b/components/crash/core/browser/crashes_ui_util.cc

@@ -43,8 +43,9 @@ void UploadListToValue(UploadList* upload_list, base::ListValue* out_value) {

for (const auto& info : crashes) {

base::DictionaryValue* crash = new base::DictionaryValue();

- crash->SetString("id", info.id);

- crash->SetString("time", base::TimeFormatFriendlyDateAndTime(info.time));

+ crash->SetString("id", info.upload_id);

+ crash->SetString("time",

+ base::TimeFormatFriendlyDateAndTime(info.upload_time));

crash->SetString("local_id", info.local_id);

out_value->Append(crash);

}