android_webview/native/aw_web_contents_delegate.h - Issue 1405333005: Defer loads on WebView popup windows until webcontents delegate attached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_web_contents_delegate.h

Issue 1405333005: Defer loads on WebView popup windows until webcontents delegate attached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move request resuming to receivePopupContents. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwContents.java ('K') | « android_webview/native/aw_contents.cc ('k') | android_webview/native/aw_web_contents_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_web_contents_delegate.h

diff --git a/android_webview/native/aw_web_contents_delegate.h b/android_webview/native/aw_web_contents_delegate.h

index 81695d081b672dc2e4a0d812a047455210343586..e9f7f697e4d8f5a5a475b53abee8904354b6c80b 100644

--- a/android_webview/native/aw_web_contents_delegate.h

+++ b/android_webview/native/aw_web_contents_delegate.h

@@ -51,6 +51,7 @@ class AwWebContentsDelegate

void ActivateContents(content::WebContents* contents) override;

void LoadingStateChanged(content::WebContents* source,

bool to_different_document) override;

+ bool ShouldResumeRequestsForCreatedWindow() override;

void RequestMediaAccessPermission(

content::WebContents* web_contents,

const content::MediaStreamRequest& request,