android_webview/native/aw_contents.cc - Issue 1405333005: Defer loads on WebView popup windows until webcontents delegate attached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.cc

Issue 1405333005: Defer loads on WebView popup windows until webcontents delegate attached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move request resuming to receivePopupContents. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwContents.java ('K') | « android_webview/native/aw_contents.h ('k') | android_webview/native/aw_web_contents_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents.cc

diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc

index e10eab626137ea1752df3bcd80a91785437f7c94..2512d69f8179ded33996ed146df3f6fe09b76624 100644

--- a/android_webview/native/aw_contents.cc

+++ b/android_webview/native/aw_contents.cc

@@ -1223,6 +1223,11 @@ void AwContents::GrantFileSchemeAccesstoChildProcess(JNIEnv* env, jobject obj) {

web_contents_->GetRenderProcessHost()->GetID(), url::kFileScheme);

}

+void AwContents::ResumeLoadingCreatedPopupWebContents(JNIEnv* env,

+ jobject obj) {

+ web_contents_->ResumeLoadingCreatedWebContents();

void SetShouldDownloadFavicons(JNIEnv* env,

const JavaParamRef<jclass>& jclazz) {

g_should_download_favicons = true;