third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model.html - Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM

Unified Diff: third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model.html

Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model-expected.txt » ('j') | third_party/WebKit/Source/core/css/StylePropertySerializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model.html

diff --git a/third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model.html b/third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model.html

new file mode 100644

index 0000000000000000000000000000000000000000..26a54e9cda1060a2db3885faf049f8c73dccd1c7

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model.html

@@ -0,0 +1,30 @@

+<!DOCTYPE html>

+<style>

+#test {

+ --important:green!important;

+ --not-important:red;

+ color:var(--important);

+</style>

+<div id="test"></div>

+<script src="../../../resources/js-test.js"></script>

+<script>

+var style = document.styleSheets[0].rules[0].style;

+shouldBeEqualToString('style.getPropertyValue("--important")', "green");

+shouldBeEqualToString('style.getPropertyValue("--not-important")', "red");

+shouldBeEqualToString('style.getPropertyValue("color")', "var(--important)");

+shouldBeEqualToString('style.getPropertyPriority("--important")', "important");

+shouldBeEqualToString('style.getPropertyPriority("--not-important")', "");

+style.setProperty("--foo", "papayawhip");

+style.setProperty("--important-foo", "navajowhite", "important");

+shouldBeEqualToString('style.getPropertyValue("--foo")', "papayawhip");

+shouldBeEqualToString('style.getPropertyPriority("--foo")', "");

+shouldBeEqualToString('style.getPropertyPriority("--important-foo")', "important");

+style.setProperty("--important-foo", "")

+shouldBeEqualToString('style.getPropertyValue("--important-foo")', "");

+shouldBeEqualToString('style.removeProperty("--foo")', "papayawhip");

+shouldBeEqualToString('style.getPropertyValue("--foo")', "");

+var computedStyle = window.getComputedStyle(document.getElementById("test"));

+shouldThrow('computedStyle.setProperty("--error", "")',

+ '"NoModificationAllowedError: Failed to execute \'setProperty\' on \'CSSStyleDeclaration\': These styles are computed, and therefore the \'--error\' property is read-only."');

alancutter (OOO until 2018) 2015/11/17 07:10:42 Does this pass? I don't think getPropertyNameStrin

leviw_travelin_and_unemployed 2015/11/17 07:23:44 It does pass.

Timothy Loh 2015/11/19 00:47:42 I had a look, CSSComputedStyleDeclaration::setProp

+</script>