third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model.html - Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model.html

Issue 1405293012: [Variables] Enable get/setProperty and similar APIs from the CSSOM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-in-object-model-expected.txt » ('j') | third_party/WebKit/Source/core/css/StylePropertySerializer.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #test {

	4 --important:green!important;

	5 --not-important:red;

	6 color:var(--important);

	7 }

	8 </style>

	9 <div id="test"></div>

	10 <script src="../../../resources/js-test.js"></script>

	11 <script>

	12 var style = document.styleSheets[0].rules[0].style;

	13 shouldBeEqualToString('style.getPropertyValue("--important")', "green");

	14 shouldBeEqualToString('style.getPropertyValue("--not-important")', "red");

	15 shouldBeEqualToString('style.getPropertyValue("color")', "var(--important)");

	16 shouldBeEqualToString('style.getPropertyPriority("--important")', "important");

	17 shouldBeEqualToString('style.getPropertyPriority("--not-important")', "");

	18 style.setProperty("--foo", "papayawhip");

	19 style.setProperty("--important-foo", "navajowhite", "important");

	20 shouldBeEqualToString('style.getPropertyValue("--foo")', "papayawhip");

	21 shouldBeEqualToString('style.getPropertyPriority("--foo")', "");

	22 shouldBeEqualToString('style.getPropertyPriority("--important-foo")', "important ");

	23 style.setProperty("--important-foo", "")

	24 shouldBeEqualToString('style.getPropertyValue("--important-foo")', "");

	25 shouldBeEqualToString('style.removeProperty("--foo")', "papayawhip");

	26 shouldBeEqualToString('style.getPropertyValue("--foo")', "");

	27 var computedStyle = window.getComputedStyle(document.getElementById("test"));

	28 shouldThrow('computedStyle.setProperty("--error", "")',

	29 '"NoModificationAllowedError: Failed to execute \'setProperty\' on \'CSSStyl eDeclaration\': These styles are computed, and therefore the \'--error\' propert y is read-only."');
	alancutter (OOO until 2018) 2015/11/17 07:10:42 Does this pass? I don't think getPropertyNameStrin Does this pass? I don't think getPropertyNameString() works for custom properties. leviw_travelin_and_unemployed 2015/11/17 07:23:44 It does pass. Show quoted text On 2015/11/17 at 07:10:42, alancutter wrote: > Does this pass? I don't think getPropertyNameString() works for custom properties. It does pass. Timothy Loh 2015/11/19 00:47:42 I had a look, CSSComputedStyleDeclaration::setProp Show quoted text On 2015/11/17 07:23:44, leviw wrote: > On 2015/11/17 at 07:10:42, alancutter wrote: > > Does this pass? I don't think getPropertyNameString() works for custom > properties. > > It does pass. I had a look, CSSComputedStyleDeclaration::setPropertyInternal seems unreachable at this point. Maybe add a TODO to fix it up later.
	30 </script>

OLD	NEW