Issue 1405293007: Bugfix in process handle: Do detaching from owner process separately from derefing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1405293007: Bugfix in process handle: Do detaching from owner process separately from derefing. (Closed)

Created:
5 years, 1 month ago by kustermann

Modified:
5 years, 1 month ago

Reviewers:
kasperl

CC:
fletch+reviews_googlegroups.com

Base URL:
git@github.com:dart-lang/fletch.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Bugfix in process handle: Do detaching from owner process separately from derefing. R=kasperl@google.com Committed: https://github.com/dart-lang/fletch/commit/e69ea8a14303c1d5912c70dc7a3b162b8e165109

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -16 lines)			Patch
M	src/vm/process.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/vm/process_handle.h	View	1 chunk	+4 lines, -9 lines	1 comment	Download
M	src/vm/refcounted.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kustermann

https://codereview.chromium.org/1405293007/diff/1/src/vm/process_handle.h File src/vm/process_handle.h (left): https://codereview.chromium.org/1405293007/diff/1/src/vm/process_handle.h#oldcode33 src/vm/process_handle.h:33: handle->lock()->Unlock(); The DecrementRefWithoutDelete() & Unlock/Delete is atomic and therefore ...

5 years, 1 month ago (2015-10-29 11:17:20 UTC) #2

kustermann

5 years, 1 month ago (2015-10-29 11:45:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e69ea8a14303c1d5912c70dc7a3b162b8e165109 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages