Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: src/vm/process.cc

Issue 1405293007: Bugfix in process handle: Do detaching from owner process separately from derefing. (Closed) Base URL: git@github.com:dart-lang/fletch.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/vm/process_handle.h » ('j') | src/vm/process_handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/vm/process.cc
diff --git a/src/vm/process.cc b/src/vm/process.cc
index a7037e2b844d02f5cf3ffa05ab94a7736de0d89d..547bb395aea7eeaa8388ea3a08a320433a2aebbc 100644
--- a/src/vm/process.cc
+++ b/src/vm/process.cc
@@ -109,6 +109,8 @@ Process::~Process() {
// conditions here.
ASSERT(ports_ == NULL);
+ ProcessHandle::DecrementRef(process_handle_);
+
#ifdef FLETCH_ENABLE_MULTIPLE_PROCESS_HEAPS
heap_.ProcessWeakPointers();
#endif // #ifdef FLETCH_ENABLE_MULTIPLE_PROCESS_HEAPS
@@ -130,7 +132,7 @@ void Process::Cleanup(Signal::Kind kind) {
// We are going down at this point. If anything else is starting to
// link/monitor with this [ProcessHandle], it will fail after this line.
- ProcessHandle::OwnerProcessTerminating(process_handle_);
+ process_handle_->OwnerProcessTerminating();
// Since nobody can send us messages (or signals) at this point, we can
// propagate the exit signal.
« no previous file with comments | « no previous file | src/vm/process_handle.h » ('j') | src/vm/process_handle.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698