Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1405273004: Make DMSrcSink fail fatally when decodeRegion() fails for BRDSrcs (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@brd-new-apis
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make DMSrcSink fail fatally when decodeRegion() fails for BRDSrcs This involves disabling webps for kCanvas_Strategy. We have not yet implemented webp subset decodes for this strategy. BUG=skia:4521 Committed: https://skia.googlesource.com/skia/+/c37799282ff7dc8cbec7e2b7ed2f6df6cdddf6a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M dm/DMSrcSink.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M tools/SkBitmapRegionDecoderInterface.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405273004/1
5 years, 1 month ago (2015-10-27 20:10:31 UTC) #3
msarett
I've tested locally and on Android, and I think this change is enough. But I'll ...
5 years, 1 month ago (2015-10-27 20:13:40 UTC) #6
scroggo
lgtm
5 years, 1 month ago (2015-10-27 20:21:38 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-27 20:25:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405273004/1
5 years, 1 month ago (2015-10-27 20:27:53 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 20:28:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c37799282ff7dc8cbec7e2b7ed2f6df6cdddf6a6

Powered by Google App Engine
This is Rietveld 408576698