Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Unified Diff: tools/SkBitmapRegionDecoderInterface.cpp

Issue 1405273004: Make DMSrcSink fail fatally when decodeRegion() fails for BRDSrcs (Closed) Base URL: https://skia.googlesource.com/skia.git@brd-new-apis
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DMSrcSink.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/SkBitmapRegionDecoderInterface.cpp
diff --git a/tools/SkBitmapRegionDecoderInterface.cpp b/tools/SkBitmapRegionDecoderInterface.cpp
index 59415383d3669876c257f68e36d8c9e55398f0fe..d009b27f3a3dd5cbc160a1a23906557878248de0 100644
--- a/tools/SkBitmapRegionDecoderInterface.cpp
+++ b/tools/SkBitmapRegionDecoderInterface.cpp
@@ -44,6 +44,13 @@ SkBitmapRegionDecoderInterface* SkBitmapRegionDecoderInterface::CreateBitmapRegi
SkCodecPrintf("Error: Failed to create decoder.\n");
return nullptr;
}
+
+ if (SkEncodedFormat::kWEBP_SkEncodedFormat == codec->getEncodedFormat()) {
+ // FIXME: Support webp using a special case. Webp does not support
+ // scanline decoding.
+ return nullptr;
+ }
+
switch (codec->getScanlineOrder()) {
case SkCodec::kTopDown_SkScanlineOrder:
case SkCodec::kNone_SkScanlineOrder:
« no previous file with comments | « dm/DMSrcSink.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698