client/simulate_crash_mac.cc - Issue 1405273002: Mach port scopers should use get() instead of type conversion operators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/simulate_crash_mac.cc

Issue 1405273002: Mach port scopers should use get() instead of type conversion operators (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: More is_valid() Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/simulate_crash_mac.cc

diff --git a/client/simulate_crash_mac.cc b/client/simulate_crash_mac.cc

index cda6b76d201e5c39ec8ee902231bacc87786c92a..71d5d904f7a13932bdb97565e356cb353a1b16bc 100644

--- a/client/simulate_crash_mac.cc

+++ b/client/simulate_crash_mac.cc

@@ -221,7 +221,7 @@ void SimulateCrash(const NativeCPUContext& cpu_context) {

DCHECK_LE(handlers.size(), 1u);

if (handlers.size() == 1) {

DCHECK(handlers[0].mask & EXC_MASK_CRASH);

- success = DeliverException(thread,

+ success = DeliverException(thread.get(),

mach_task_self(),

exception,

codes,

« no previous file with comments | « client/crashpad_client_mac.cc ('k') | handler/mac/crash_report_exception_handler.cc » ('j') | no next file with comments »