Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1405263002: Add comments to HttpNetworkSession::Params (Closed)

Created:
5 years, 2 months ago by Ryan Hamilton
Modified:
5 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comments to HttpNetworkSession::Params Committed: https://crrev.com/d502a300cb1aa4fa99983c0446e5637b45724a16 Cr-Commit-Position: refs/heads/master@{#354441}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M net/http/http_network_session.h View 1 2 chunks +40 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Ryan Hamilton
5 years, 2 months ago (2015-10-16 02:19:43 UTC) #2
ramant (doing other things)
LGTM. Thanks for doing this. https://codereview.chromium.org/1405263002/diff/1/net/http/http_network_session.h File net/http/http_network_session.h (right): https://codereview.chromium.org/1405263002/diff/1/net/http/http_network_session.h#newcode157 net/http/http_network_session.h:157: // Source of entropy ...
5 years, 2 months ago (2015-10-16 02:25:09 UTC) #3
Ryan Hamilton
Thanks, Raman. https://codereview.chromium.org/1405263002/diff/1/net/http/http_network_session.h File net/http/http_network_session.h (right): https://codereview.chromium.org/1405263002/diff/1/net/http/http_network_session.h#newcode157 net/http/http_network_session.h:157: // Source of entropy for QUIC connections. ...
5 years, 2 months ago (2015-10-16 02:29:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405263002/20001
5 years, 2 months ago (2015-10-16 02:30:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 03:57:30 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 03:58:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d502a300cb1aa4fa99983c0446e5637b45724a16
Cr-Commit-Position: refs/heads/master@{#354441}

Powered by Google App Engine
This is Rietveld 408576698