Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1405253004: Precompilation: Including generative constructor entry points should mark a class as instantiated. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation: Including generative constructor entry points should mark a class as instantiated. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/a08d80b25a57c0ff6a79ed1b397dbc48fc3adb58

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M runtime/vm/precompiler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 1 6 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 2 months ago (2015-10-16 20:02:37 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1405253004/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/1405253004/diff/1/runtime/vm/precompiler.cc#newcode290 runtime/vm/precompiler.cc:290: AddClass(cls); Maybe AddInstantiatedClass?
5 years, 2 months ago (2015-10-16 20:10:21 UTC) #3
rmacnak
https://codereview.chromium.org/1405253004/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/1405253004/diff/1/runtime/vm/precompiler.cc#newcode290 runtime/vm/precompiler.cc:290: AddClass(cls); On 2015/10/16 20:10:21, srdjan wrote: > Maybe AddInstantiatedClass? ...
5 years, 2 months ago (2015-10-16 20:31:02 UTC) #4
rmacnak
5 years, 2 months ago (2015-10-16 20:32:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a08d80b25a57c0ff6a79ed1b397dbc48fc3adb58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698