Precompilation: Including generative constructor entry points should mark a class as instantiated.

runtime/vm/precompiler.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/precompiler.h"
 
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/isolate.h"
 #include "vm/log.h"
@@ skipping 264 matching lines @@
       if (FLAG_trace_precompiler) {
         THR_Print("WARNING: Missing %s %s %s\n",
                   entry_points[i].library_uri,
                   entry_points[i].class_name,
                   entry_points[i].function_name);
       }
       continue;
     }
 
     AddFunction(func);
+    if (func.IsGenerativeConstructor()) {
+      // Allocation stubs are referenced from the call site of the constructor,
+      // not in the constructor itself. So compiling the constructor isn't
+      // enough for us to discover the class is instantiated if the class isn't
+      // otherwise instantiated from Dart code and only instantiated from C++.
+      AddClass(cls);

[srdjan, 2015/10/16 20:10:21]

Maybe AddInstantiatedClass?

[rmacnak, 2015/10/16 20:31:02]

That's better.

+    }
   }
 }
 
 
 void Precompiler::Iterate() {
   Function& function = Function::Handle(Z);
 
   while (changed_) {
     changed_ = false;
 
@@ skipping 571 matching lines @@
         continue;  // class 'dynamic' is in the read-only VM isolate.
       }
       cls.EnsureIsFinalized(T);
     }
   }
   I->set_all_classes_finalized(true);
 }
 
 
 }  // namespace dart