Issue 1405243004: Merge to XFA: DEPS include_rules no longer allows core/ -> fpsdfsk/ inclusion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1405243004: Merge to XFA: DEPS include_rules no longer allows core/ -> fpsdfsk/ inclusion. (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: DEPS include_rules no longer allows core/ -> fpsdfsk/ inclusion. Original Review URL: https://codereview.chromium.org/1411493002 . (cherry picked from commit 8316a8a0274558f7a0f515e04bb13a7cca5762b2) BUG=pdfium:217 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a03709ea217218126b09bef8bb332cb943a494dd

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -2 lines)			Patch
M	DEPS	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	fpdfsdk/DEPS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	samples/DEPS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	testing/DEPS	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as a03709ea217218126b09bef8bb332cb943a494dd (presubmit successful).

5 years, 2 months ago (2015-10-16 16:44:53 UTC) #2

Message was sent while issue was closed.

lgtm