Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411493002: DEPS include_rules no longer allows core/ -> fpsdfsk/ inclusion. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DEPS include_rules no longer allows core/ -> fpsdfsk/ inclusion. Adds the following new violations: ERROR in core/include/fpdfapi/fpdf_parser.h Illegal include: "public/fpdfview.h" ERROR in core/include/fpdfapi/fpdf_render.h Illegal include: "public/fpdf_progressive.h" ERROR in core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp Illegal include: "public/fpdfview.h" BUG=pdfium:217 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8316a8a0274558f7a0f515e04bb13a7cca5762b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M samples/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M testing/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review.
5 years, 2 months ago (2015-10-15 20:10:24 UTC) #2
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-16 01:30:12 UTC) #3
Tom Sepez
5 years, 2 months ago (2015-10-16 16:38:39 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8316a8a0274558f7a0f515e04bb13a7cca5762b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698