Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1405103003:
Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader (Closed)
DescriptionRemove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader
Use an SkImage generator/shader instead.
R=reed@google.com
Committed: https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d
Committed: https://skia.googlesource.com/skia/+/1b46a573656ec057eac300b34d1deff8526a559e
Patch Set 1 #Patch Set 2 : use the actual generator SkImageInfo #Patch Set 3 : comment #
Total comments: 1
Messages
Total messages: 24 (9 generated)
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405103003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405103003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405103003/20001
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405103003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405103003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
https://codereview.chromium.org/1405103003/diff/40001/src/core/SkPictureShade... File src/core/SkPictureShader.cpp (right): https://codereview.chromium.org/1405103003/diff/40001/src/core/SkPictureShade... src/core/SkPictureShader.cpp:230: const SkImageInfo tileInfo = tileGenerator->getInfo(); Can we replace these to New calls with just static SkImage* NewFromPicture(const SkPicture*, const SkISize& dimensions, const SkMatrix*, const SkPaint*);
On 2015/10/16 14:12:19, reed1 wrote: > https://codereview.chromium.org/1405103003/diff/40001/src/core/SkPictureShade... > File src/core/SkPictureShader.cpp (right): > > https://codereview.chromium.org/1405103003/diff/40001/src/core/SkPictureShade... > src/core/SkPictureShader.cpp:230: const SkImageInfo tileInfo = > tileGenerator->getInfo(); > Can we replace these to New calls with just > > static SkImage* NewFromPicture(const SkPicture*, const SkISize& dimensions, > const SkMatrix*, const SkPaint*); That was my original patch, but then we don't have access to the actual generator SkImageInfo to grab the size and making one up seemed fragile. I can switch back to that version since it's simpler.
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405103003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405103003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1407043008/ by caryclark@google.com. The reason for reverting is: Test to see if patch fixes Nexus 6..
Message was sent while issue was closed.
Description was changed from ========== Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader Use an SkImage generator/shader instead. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d ========== to ========== Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader Use an SkImage generator/shader instead. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d ==========
I tried another N6 run and it is now passing: https://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Ne... Let's try to land this again.
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405103003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405103003/40001
Message was sent while issue was closed.
Description was changed from ========== Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader Use an SkImage generator/shader instead. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d ========== to ========== Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader Use an SkImage generator/shader instead. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d Committed: https://skia.googlesource.com/skia/+/1b46a573656ec057eac300b34d1deff8526a559e ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/1b46a573656ec057eac300b34d1deff8526a559e |
