Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1405033002: Issue 24599. Fix for requesting navigation for directives. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_navigation_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-15 17:45:25 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-15 17:50:55 UTC) #2
scheglov
5 years, 2 months ago (2015-10-15 17:54:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a30bcd7b97c5d4704b27c99ba9cf8d85b527bb83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698