Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: pkg/analysis_server/test/analysis/notification_navigation_test.dart

Issue 1405033002: Issue 24599. Fix for requesting navigation for directives. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/analysis/get_navigation_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/analysis/notification_navigation_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_navigation_test.dart b/pkg/analysis_server/test/analysis/notification_navigation_test.dart
index 4accf976e9c9bc28f9223957af12414bd009a5e5..5e66eca77f7f05dc3bd2bbfdfe7f91356e16410c 100644
--- a/pkg/analysis_server/test/analysis/notification_navigation_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_navigation_test.dart
@@ -26,6 +26,7 @@ class AbstractNavigationTest extends AbstractAnalysisTest {
NavigationRegion testRegion;
List<int> testTargetIndexes;
+ List<NavigationTarget> testTargets;
NavigationTarget testTarget;
/**
@@ -33,8 +34,6 @@ class AbstractNavigationTest extends AbstractAnalysisTest {
* at [offset] and with the given [length].
*/
void assertHasFileTarget(String file, int offset, int length) {
- List<NavigationTarget> testTargets =
- testTargetIndexes.map((int index) => targets[index]).toList();
for (NavigationTarget target in testTargets) {
if (targetFiles[target.fileIndex] == file &&
target.offset == offset &&
@@ -167,6 +166,7 @@ class AbstractNavigationTest extends AbstractAnalysisTest {
}
testRegion = region;
testTargetIndexes = region.targets;
+ testTargets = testTargetIndexes.map((i) => targets[i]).toList();
return;
}
}
« no previous file with comments | « pkg/analysis_server/test/analysis/get_navigation_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698