Add debug shortcuts that toggles options to shows paint rects

Add debug shortcuts that toggles options to shows paint rects.
Cleanup: Separate desktop shortcuts which are useful only on linux desktop, and debug shortcuts.

BUG=227375
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195733

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195854

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196911

[James Cook, 2013-04-22 21:51:58]

Did you forget to add debug.h/debug.cc?

https://codereview.chromium.org/14050009/diff/5001/ash/accelerators/accelerat...
File ash/accelerators/accelerator_table.cc (right):

https://codereview.chromium.org/14050009/diff/5001/ash/accelerators/accelerat...
ash/accelerators/accelerator_table.cc:255: PRINT_LAYER_HIERARCHY,
Alphabetize these

https://codereview.chromium.org/14050009/diff/5001/ash/accelerators/accelerat...
ash/accelerators/accelerator_table.cc:364: PRINT_LAYER_HIERARCHY,
Alphabetize

https://codereview.chromium.org/14050009/diff/5001/ash/accelerators/accelerat...
File ash/accelerators/accelerator_table.h (right):

https://codereview.chromium.org/14050009/diff/5001/ash/accelerators/accelerat...
ash/accelerators/accelerator_table.h:119: // Debug accelerators enabled only on
debug build.
Debug build?  Or desktop build?

[oshima, 2013-04-22 23:07:40]

Doh, added debug.{cc|h}

Sorted actions everywhere. Moved #ifdef to the end in the list.

@piman, I had to add dependency to cc/debug. If this is not
desirable, I'll add separate methods to compositor. Please
let me know.

https://codereview.chromium.org/14050009/diff/5001/ash/accelerators/accelerat...
File ash/accelerators/accelerator_table.h (right):

https://codereview.chromium.org/14050009/diff/5001/ash/accelerators/accelerat...
ash/accelerators/accelerator_table.h:119: // Debug accelerators enabled only on
debug build.
On 2013/04/22 21:51:58, James Cook (Chromium) wrote:
> Debug build?  Or desktop build?

updated the comment.

[James Cook, 2013-04-22 23:52:57]

ash/* LGTM

I would prefer not to add the dependency on cc/debug to ash/DEPS, but I defer to
piman about whether that is better or worse than the extra methods required in
ui/compositor.

[piman, 2013-04-23 00:53:51]

On 2013/04/22 23:52:57, James Cook (Chromium) wrote:
> ash/* LGTM
> 
> I would prefer not to add the dependency on cc/debug to ash/DEPS, but I defer
to
> piman about whether that is better or worse than the extra methods required in
> ui/compositor.

LGTM
I don't have a problem with it either way, up to you.

[piman, 2013-04-23 00:54:30]

https://codereview.chromium.org/14050009/diff/13001/ash/debug.cc
File ash/debug.cc (right):

https://codereview.chromium.org/14050009/diff/13001/ash/debug.cc#newcode22
ash/debug.cc:22: state.show_debug_borders = !state.show_debug_borders;
it would be better to figure out the right value first (e.g. from the first
window), and set the same thing on each tree.
Otherwise you could run into the case where:
- one tree gets this turned on
- you plug in an external screen, that one doesn't get this turned on
- the toggle key toggles each compositor, meaning you still have one on and one
off - can't have both on or both off.

(same in other functions below)

[oshima, 2013-04-23 01:18:58]

https://codereview.chromium.org/14050009/diff/13001/ash/debug.cc
File ash/debug.cc (right):

https://codereview.chromium.org/14050009/diff/13001/ash/debug.cc#newcode22
ash/debug.cc:22: state.show_debug_borders = !state.show_debug_borders;
On 2013/04/23 00:54:30, piman wrote:
> it would be better to figure out the right value first (e.g. from the first
> window), and set the same thing on each tree.
> Otherwise you could run into the case where:
> - one tree gets this turned on
> - you plug in an external screen, that one doesn't get this turned on
> - the toggle key toggles each compositor, meaning you still have one on and
one
> off - can't have both on or both off.
> 
> (same in other functions below)

ok, done.

[piman, 2013-04-23 02:18:14]

lgtm

[commit-bot: I haz the power, 2013-04-23 02:22:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/20003

[commit-bot: I haz the power, 2013-04-23 02:41:46]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, content_unittests, crypto_unittests, googleurl_unittests,
media_unittests, net_unittests, sql_unittests, ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-04-23 02:59:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/20003

[commit-bot: I haz the power, 2013-04-23 05:48:23]

Change committed as 195733

[commit-bot: I haz the power, 2013-04-23 08:35:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 08:35:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 08:36:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 08:36:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 08:36:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 08:36:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 08:37:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 08:37:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 08:38:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 08:40:59]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-23 15:46:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 15:47:51]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-23 17:33:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/36001

[commit-bot: I haz the power, 2013-04-23 18:38:15]

Change committed as 195854

[oshima, 2013-04-26 21:02:13]

@piman, can you take another look at compositor change?
win_aura bot was failing due to missing LayerTreeDebugState's  dtor symbol, and
I replace them with boolean for the time being.

[piman, 2013-04-26 21:05:58]

On 2013/04/26 21:02:13, oshima wrote:
> @piman, can you take another look at compositor change?
> win_aura bot was failing due to missing LayerTreeDebugState's  dtor symbol,
and
> I replace them with boolean for the time being.

Sure, LGTM.
It was probably just a missing deps though, wasn't it?

[oshima, 2013-04-26 21:16:14]

On 2013/04/26 21:05:58, piman wrote:
> On 2013/04/26 21:02:13, oshima wrote:
> > @piman, can you take another look at compositor change?
> > win_aura bot was failing due to missing LayerTreeDebugState's  dtor symbol,
> and
> > I replace them with boolean for the time being.
> 
> Sure, LGTM.
> It was probably just a missing deps though, wasn't it?

Probably, but I'd like to land this first. Unfortunately, waterfall bot
is using shared_library, while CQ/try bots are using static_library, and
I need to verify it locally, which I'm having trouble with.
 I'll fix this in separate CL.

[commit-bot: I haz the power, 2013-04-26 21:17:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/15003

[commit-bot: I haz the power, 2013-04-26 21:25:53]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-26 21:28:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/63006

[commit-bot: I haz the power, 2013-04-26 21:40:18]

Retried try job too often on linux_chromeos for step(s) ash_unittests,
aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests,
check_deps, chromeos_unittests, components_unittests, content_browsertests,
content_unittests, crypto_unittests, dbus_unittests, device_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, net_unittests, ppapi_unittests, printing_unittests,
sandbox_linux_unittests, sql_unittests, sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[oshima, 2013-04-26 21:43:35]

On 2013/04/26 21:40:18, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_chromeos for step(s) ash_unittests,
> aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests,
> check_deps, chromeos_unittests, components_unittests, content_browsertests,
> content_unittests, crypto_unittests, dbus_unittests, device_unittests,
> gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
> media_unittests, net_unittests, ppapi_unittests, printing_unittests,
> sandbox_linux_unittests, sql_unittests, sync_unit_tests, unit_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

> /bin/sh: 1: g++: not found

hmm.... :(

[commit-bot: I haz the power, 2013-04-26 21:44:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/63006

[commit-bot: I haz the power, 2013-04-26 21:56:34]

Retried try job too often on linux_aura for step(s) aura_unittests,
browser_tests, compositor_unittests, content_browsertests, content_unittests,
interactive_ui_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-04-26 23:02:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/63006

[commit-bot: I haz the power, 2013-04-26 23:14:27]

Retried try job too often on linux_aura for step(s) aura_unittests,
browser_tests, compositor_unittests, content_browsertests, content_unittests,
interactive_ui_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-04-27 00:38:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/14050009/63006

[commit-bot: I haz the power, 2013-04-27 01:53:42]

Change committed as 196911