Issue 14049016: Enable new dialog style transparency with Views Textfields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14049016: Enable new dialog style transparency with Views Textfields. (Closed)

Created:
7 years, 8 months ago by msw

Modified:
7 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable new dialog style transparency with Views Textfields. This makes new-style Dialog widgets transparent on non-Aura Win. Use Views Textfields if the new dialog style switch is specified. ( transparency prohibits hosting native Windows textfield controls ) ( new-dialog-style + win-textfields is possible but breaks dialog textfields ) See the border of before/after pics at http://crbug.com/166075#c46 BUG=166075, 231012 TEST=Non-Aura Win new-style dialogs don't have any extra black/glass border. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194292

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	ui/views/controls/textfield/textfield.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	ui/views/window/dialog_delegate.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

msw

7 years, 8 months ago (2013-04-16 04:41:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194292 (presubmit successful).

Expand Messages | Collapse Messages