Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1856)

Unified Diff: ui/views/window/dialog_delegate.cc

Issue 14049016: Enable new dialog style transparency with Views Textfields. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/textfield/textfield.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/window/dialog_delegate.cc
diff --git a/ui/views/window/dialog_delegate.cc b/ui/views/window/dialog_delegate.cc
index a3ef79b23a55fadfee0fb49dd27bf3d1d9cec22f..a6f2732c388135ed834a6f388f69402992857f01 100644
--- a/ui/views/window/dialog_delegate.cc
+++ b/ui/views/window/dialog_delegate.cc
@@ -32,9 +32,8 @@ Widget* CreateDialogWidgetImpl(DialogDelegateView* dialog_delegate_view,
views::Widget::InitParams params;
params.delegate = dialog_delegate_view;
if (DialogDelegate::UseNewStyle()) {
- // TODO(msw): Avoid Windows native controls or support dialog transparency
- // with a separate border Widget, like BubbleDelegateView.
- params.transparent = views::View::get_use_acceleration_when_possible();
+ // Note: Transparent widgets cannot host native Windows textfield controls.
+ params.transparent = true;
params.remove_standard_frame = true;
}
params.context = context;
« no previous file with comments | « ui/views/controls/textfield/textfield.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698