Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404783002: Debugger: allow stepping into resolver from Promise constructor. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: allow stepping into resolver from Promise constructor. R=rossberg@chromium.org BUG=chromium:451967 LOG=N Committed: https://crrev.com/73c9be9b31d2e7fa86f4effd36fcc2047a6bf9b3 Cr-Commit-Position: refs/heads/master@{#31296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -111 lines) Patch
M src/js/array.js View 7 chunks +7 lines, -7 lines 0 comments Download
M src/js/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/js/generator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/js/promise.js View 2 chunks +2 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +43 lines, -19 lines 0 comments Download
A + test/mjsunit/es6/debug-promises/stepin-constructor.js View 3 chunks +22 lines, -12 lines 0 comments Download
A + test/mjsunit/es6/debug-promises/stepin-handler.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/mjsunit/es6/debug-stepin-promises.js View 1 chunk +0 lines, -65 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-401915.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 2 months ago (2015-10-14 13:47:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404783002/1
5 years, 2 months ago (2015-10-15 08:00:16 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-15 08:36:43 UTC) #5
rossberg
lgtm
5 years, 2 months ago (2015-10-15 12:01:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404783002/1
5 years, 2 months ago (2015-10-15 12:25:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 12:27:30 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 12:27:50 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/73c9be9b31d2e7fa86f4effd36fcc2047a6bf9b3
Cr-Commit-Position: refs/heads/master@{#31296}

Powered by Google App Engine
This is Rietveld 408576698