Debugger: allow stepping into resolver from Promise constructor.

src/runtime/runtime-debug.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/runtime/runtime-utils.h"
 
 #include "src/arguments.h"
 #include "src/debug/debug.h"
 #include "src/debug/debug-evaluate.h"
 #include "src/debug/debug-frames.h"
@@ skipping 1594 matching lines @@
         break;
       }
     }
   }
 
   if (found.is_null()) return isolate->heap()->undefined_value();
   return *Script::GetWrapper(found);
 }
 
 
+bool DebugStepInIsActive(Debug* debug) {
+  return debug->is_active() && debug->IsStepping() &&
+         debug->last_step_action() == StepIn;
+}
+
+
 // Check whether debugger is about to step into the callback that is passed
-// to a built-in function such as Array.forEach.
+// to a built-in function such as Array.forEach. This check is done before
+// %DebugPrepareStepInIfStepping and is not strictly necessary. However, if it
+// returns false, we can skip %DebugPrepareStepInIfStepping, useful in loops.
 RUNTIME_FUNCTION(Runtime_DebugCallbackSupportsStepping) {
+  SealHandleScope shs(isolate);
   DCHECK(args.length() == 1);
-  Debug* debug = isolate->debug();
-  if (!debug->is_active() || !debug->IsStepping() ||
-      debug->last_step_action() != StepIn) {
+  if (!DebugStepInIsActive(isolate->debug())) {
     return isolate->heap()->false_value();
   }
-  CONVERT_ARG_CHECKED(Object, callback, 0);
+  CONVERT_ARG_CHECKED(Object, object, 0);
+  RUNTIME_ASSERT(object->IsJSFunction() || object->IsJSGeneratorObject());
   // We do not step into the callback if it's a builtin other than a bound,
   // or not even a function.
-  return isolate->heap()->ToBoolean(
-      callback->IsJSFunction() &&
-      (JSFunction::cast(callback)->IsSubjectToDebugging() ||
-       JSFunction::cast(callback)->shared()->bound()));
+  JSFunction* fun;
+  if (object->IsJSFunction()) {
+    fun = JSFunction::cast(object);
+  } else {
+    fun = JSGeneratorObject::cast(object)->function();
+  }
+  return isolate->heap()->ToBoolean(fun->IsSubjectToDebugging() ||
+                                    fun->shared()->bound());
+}
+
+
+void FloodDebugSubjectWithOneShot(Debug* debug, Handle<JSFunction> function) {
+  if (function->IsSubjectToDebugging() || function->shared()->bound()) {
+    // When leaving the function, step out has been activated, but not performed
+    // if we do not leave the builtin.  To be able to step into the function
+    // again, we need to clear the step out at this point.
+    debug->ClearStepOut();
+    debug->FloodWithOneShotGeneric(function);
+  }
 }
 
 
 // Set one shot breakpoints for the callback function that is passed to a
-// built-in function such as Array.forEach to enable stepping into the callback.
+// built-in function such as Array.forEach to enable stepping into the callback,
+// if we are indeed stepping and the callback is subject to debugging.
 RUNTIME_FUNCTION(Runtime_DebugPrepareStepInIfStepping) {
   DCHECK(args.length() == 1);
-  RUNTIME_ASSERT(isolate->debug()->is_active());
-
   Debug* debug = isolate->debug();
-  if (!debug->IsStepping()) return isolate->heap()->undefined_value();
+  if (!DebugStepInIsActive(debug)) return isolate->heap()->undefined_value();
 
   HandleScope scope(isolate);
   CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);
   RUNTIME_ASSERT(object->IsJSFunction() || object->IsJSGeneratorObject());
   Handle<JSFunction> fun;
   if (object->IsJSFunction()) {
     fun = Handle<JSFunction>::cast(object);
   } else {
     fun = Handle<JSFunction>(
         Handle<JSGeneratorObject>::cast(object)->function(), isolate);
   }
-  // When leaving the function, step out has been activated, but not performed
-  // if we do not leave the builtin.  To be able to step into the function
-  // again, we need to clear the step out at this point.
-  debug->ClearStepOut();
-  debug->FloodWithOneShotGeneric(fun);
+
+  FloodDebugSubjectWithOneShot(debug, fun);
   return isolate->heap()->undefined_value();
 }
 
 
 RUNTIME_FUNCTION(Runtime_DebugPushPromise) {
-  DCHECK(args.length() == 2);
+  DCHECK(args.length() == 3);
   HandleScope scope(isolate);
   CONVERT_ARG_HANDLE_CHECKED(JSObject, promise, 0);
   CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 1);
+  CONVERT_ARG_HANDLE_CHECKED(Object, handler, 2);
   isolate->PushPromise(promise, function);
+  Debug* debug = isolate->debug();
+  if (handler->IsJSFunction() && DebugStepInIsActive(debug)) {
+    FloodDebugSubjectWithOneShot(debug, Handle<JSFunction>::cast(handler));
+  }
   return isolate->heap()->undefined_value();
 }
 
 
 RUNTIME_FUNCTION(Runtime_DebugPopPromise) {
   DCHECK(args.length() == 0);
   SealHandleScope shs(isolate);
   isolate->PopPromise();
   return isolate->heap()->undefined_value();
 }
@@ skipping 33 matching lines @@
   return *isolate->factory()->undefined_value();
 }
 
 
 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
   UNIMPLEMENTED();
   return NULL;
 }
 }  // namespace internal
 }  // namespace v8