Issue 1404363004: Make gcl uploading work again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1404363004: Make gcl uploading work again. (Closed)

Created:
5 years, 2 months ago by Nico

Modified:
5 years, 2 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

Make gcl uploading work again. See discussion in https://codereview.chromium.org/1213363002/ BUG=503847 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297230

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	gcl.py	View		3 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404363004/1

5 years, 2 months ago (2015-10-21 20:03:43 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-10-21 20:05:49 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297230

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages