Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gcl.py

Issue 1404363004: Make gcl uploading work again. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 297229)
+++ gcl.py (working copy)
@@ -47,8 +47,10 @@
# we store information about changelists.
REPOSITORY_ROOT = ""
-# Replacement for project name.
-SWITCH_TO_GIT = "SWITCH_TO_GIT_ALREADY"
+# Printed when people upload patches using svn.
+SWITCH_TO_GIT = """You're using svn to work on depot_tools.
+Consider switching to git today, so that you're ready when svn stops working
+and you need a functional checkout for a future fire."""
# Filename where we store repository specific information for gcl.
CODEREVIEW_SETTINGS_FILE = "codereview.settings"
@@ -884,7 +886,8 @@
project = GetCodeReviewSetting("PROJECT")
if project:
- upload_arg.append("--project=%s" % SWITCH_TO_GIT)
+ print SWITCH_TO_GIT
+ upload_arg.append("--project=%s" % project)
if not any(i.startswith('--title') or i.startswith('-t') for i in args):
upload_arg.append('--title= ')
@@ -926,7 +929,8 @@
project = GetCodeReviewSetting("PROJECT")
if project:
- upload_arg.append("--project=%s" % SWITCH_TO_GIT)
+ print SWITCH_TO_GIT
+ upload_arg.append("--project=%s" % project)
# If we have a lot of files with long paths, then we won't be able to fit
# the command to "svn diff". Instead, we generate the diff manually for
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698