Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1404193002: Merge to XFA: Add unit test for top-level bookmarks. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add unit test for top-level bookmarks. Original Review URL: https://codereview.chromium.org/1404723002 . (cherry picked from commit 7d54a9f70f977ce9b72959ef55dc6300713ccafe) R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/758ae14e113c07285126274577d7a5cab559fa65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -65 lines) Patch
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 2 chunks +39 lines, -0 lines 0 comments Download
A + testing/resources/bookmarks.in View 2 chunks +16 lines, -27 lines 0 comments Download
A + testing/resources/bookmarks.pdf View 3 chunks +27 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR, automatic.
5 years, 2 months ago (2015-10-14 16:20:01 UTC) #1
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-14 16:23:32 UTC) #2
Tom Sepez
5 years, 2 months ago (2015-10-14 16:26:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
758ae14e113c07285126274577d7a5cab559fa65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698