Issue 1404723002: Add unit test for top-level bookmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1404723002: Add unit test for top-level bookmarks. (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add unit test for top-level bookmarks. Null FPDF_BOOKMARK represents the "root" bookmark, and must not segv when asking about titles or children. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7d54a9f70f977ce9b72959ef55dc6300713ccafe

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -65 lines)			Patch
M	fpdfsdk/src/fpdfdoc_embeddertest.cpp	View	1	2 chunks	+39 lines, -0 lines	0 comments	Download
A +	testing/resources/bookmarks.in	View	1	2 chunks	+16 lines, -27 lines	0 comments	Download
A +	testing/resources/bookmarks.pdf	View	1	3 chunks	+27 lines, -38 lines	0 comments	Download

Total messages: 5 (0 generated)

Tom Sepez

On 2015/10/13 23:02:06, Tom Sepez wrote: > Lei, unit test as requested. Hang on. This ...

5 years, 2 months ago (2015-10-13 23:04:26 UTC) #2

Tom Sepez

5 years, 2 months ago (2015-10-14 16:17:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7d54a9f70f977ce9b72959ef55dc6300713ccafe (presubmit successful).