Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404133004: IWYU for autofill suggestion. (Closed)

Created:
5 years, 2 months ago by please use gerrit instead
Modified:
5 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, rouslan+autofill_chromium.org, bondd+autofillwatch_chromium.org, jdonnelly+autofillwatch_chromium.org, browser-components-watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IWYU for autofill suggestion. Include-what-you-use for autofill suggestion. Also remove 'public' keyword, because structs are public by default. BUG=NONE Committed: https://crrev.com/fbea98ab539cdf189d3d1166417939dcd8bbd5f0 Cr-Commit-Position: refs/heads/master@{#354406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M components/autofill/core/browser/suggestion.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/autofill/core/browser/suggestion.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
please use gerrit instead
Brett, PTAL.
5 years, 2 months ago (2015-10-14 14:46:19 UTC) #2
brettw
lgtm
5 years, 2 months ago (2015-10-15 22:37:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404133004/1
5 years, 2 months ago (2015-10-15 22:38:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 23:50:14 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 23:51:42 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fbea98ab539cdf189d3d1166417939dcd8bbd5f0
Cr-Commit-Position: refs/heads/master@{#354406}

Powered by Google App Engine
This is Rietveld 408576698