win: Let about:version list the C++ compiler used to build chrome.

win: Let about:version list the C++ compiler used to build chrome.

We're hoping to send out a single clang-built canary later this week, and
this will be useful for identifying that.  After that, we can remove this
row again.

BUG=82385, 530785
Committed: https://crrev.com/a5a4e4ab217da89850f1a098a0f8d61c9e5704c2
Cr-Commit-Position: refs/heads/master@{#353930}

[Nico, 2015-10-13 23:45:26]

thakis@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-10-13 23:57:29]

https://codereview.chromium.org/1404063002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/version_ui.cc (right):

https://codereview.chromium.org/1404063002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/version_ui.cc:126: #if !defined(__clang__)
shouldn't this be... if defined(__clang__)?

[Nico, 2015-10-14 00:01:49]

/me looks embarassed

https://codereview.chromium.org/1404063002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/version_ui.cc (right):

https://codereview.chromium.org/1404063002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/version_ui.cc:126: #if !defined(__clang__)
On 2015/10/13 23:57:29, Dan Beam wrote:
> shouldn't this be... if defined(__clang__)?

Codereview, it works! Thanks, fixed. I had added the ! to test both branches
locally (faster than doing a full build with another compiler) and then… :-(

[Dan Beam, 2015-10-14 00:09:06]

lgtm

[Nico, 2015-10-14 00:09:30]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-10-14 00:11:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404063002/40001

[commit-bot: I haz the power, 2015-10-14 00:55:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-14 00:56:47]

Patchset 3 (id:??) landed as
https://crrev.com/a5a4e4ab217da89850f1a098a0f8d61c9e5704c2
Cr-Commit-Position: refs/heads/master@{#353930}