Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3940)

Unified Diff: chrome/browser/ui/webui/version_ui.cc

Issue 1404063002: win: Let about:version list the C++ compiler used to build chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/about_version.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/version_ui.cc
diff --git a/chrome/browser/ui/webui/version_ui.cc b/chrome/browser/ui/webui/version_ui.cc
index 7629f50ba78808b7ce00a4b9e1f420b00302bf90..25cd92dfb5427c5d4955adaeec95ca790fac24a1 100644
--- a/chrome/browser/ui/webui/version_ui.cc
+++ b/chrome/browser/ui/webui/version_ui.cc
@@ -122,6 +122,14 @@ WebUIDataSource* CreateVersionUIDataSource() {
html_source->AddLocalizedString("variations_name",
IDS_ABOUT_VERSION_VARIATIONS);
+#if defined(OS_WIN)
+#if defined(__clang__)
+ html_source->AddString("compiler", "clang");
+#else
+ html_source->AddString("compiler", "MSVC");
+#endif
+#endif
+
html_source->SetJsonPath("strings.js");
html_source->AddResourcePath("version.js", IDR_ABOUT_VERSION_JS);
html_source->AddResourcePath("about_version.css", IDR_ABOUT_VERSION_CSS);
« no previous file with comments | « chrome/browser/resources/about_version.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698