third_party/WebKit/Source/web/LinkHighlightImplTest.cpp - Issue 1403893003: Plumb gesture source value through Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

Issue 1403893003: Plumb gesture source value through Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add GestureEventStreamValidator source device compatibility check. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

diff --git a/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp b/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

index 6fc5f595cb56dde94924e743e71f5cca92a37f1d..181110b390cc84a4b5411d5a0422e7c48a76ce8d 100644

--- a/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

+++ b/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

@@ -72,6 +72,7 @@ TEST(LinkHighlightImplTest, verifyWebViewImplIntegration)

WebGestureEvent touchEvent;

touchEvent.type = WebInputEvent::GestureShowPress;

+ touchEvent.sourceDevice = WebGestureDeviceTouchpad;

Rick Byers 2015/10/19 18:20:29 Seems very weird to set touchpad here when it's cl

wjmaclean 2015/10/19 18:58:49 Done.

// The coordinates below are linked to absolute positions in the referenced .html file.

touchEvent.x = 20;

@@ -142,6 +143,7 @@ TEST(LinkHighlightImplTest, resetDuringNodeRemoval)

WebGestureEvent touchEvent;

touchEvent.type = WebInputEvent::GestureShowPress;

+ touchEvent.sourceDevice = WebGestureDeviceTouchpad;

Rick Byers 2015/10/19 18:20:29 ditto

wjmaclean 2015/10/19 18:58:49 Done.

touchEvent.x = 20;

touchEvent.y = 20;