Plumb gesture source value through Blink.

third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 54 matching lines @@
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("test_touch_link_highlight.html"));
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(baseURL + fileName, true);
     int pageWidth = 640;
     int pageHeight = 480;
     webViewImpl->resize(WebSize(pageWidth, pageHeight));
     webViewImpl->layout();
 
     WebGestureEvent touchEvent;
     touchEvent.type = WebInputEvent::GestureShowPress;
+    touchEvent.sourceDevice = WebGestureDeviceTouchpad;

[Rick Byers, 2015/10/19 18:20:29]

Seems very weird to set touchpad here when it's clearly touchscreen.  I assume
it makes no different either way (since GestureShowPress is ALWAYS touchscreen,
we never check), can you just use touchscreen to avoid confusion?

[wjmaclean, 2015/10/19 18:58:49]

Done.

 
     // The coordinates below are linked to absolute positions in the referenced .html file.
     touchEvent.x = 20;
     touchEvent.y = 20;
 
     ASSERT_TRUE(webViewImpl->bestTapNode(getTargetedEvent(webViewImpl, touchEvent)));
 
     touchEvent.y = 40;
     EXPECT_FALSE(webViewImpl->bestTapNode(getTargetedEvent(webViewImpl, touchEvent)));
 
@@ skipping 50 matching lines @@
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(baseURL + fileName, true, 0, compositingWebViewClient());
 
     int pageWidth = 640;
     int pageHeight = 480;
     webViewImpl->resize(WebSize(pageWidth, pageHeight));
     webViewImpl->layout();
 
     WebGestureEvent touchEvent;
     touchEvent.type = WebInputEvent::GestureShowPress;
+    touchEvent.sourceDevice = WebGestureDeviceTouchpad;

[Rick Byers, 2015/10/19 18:20:29]

ditto

[wjmaclean, 2015/10/19 18:58:49]

Done.

     touchEvent.x = 20;
     touchEvent.y = 20;
 
     GestureEventWithHitTestResults targetedEvent = getTargetedEvent(webViewImpl, touchEvent);
     Node* touchNode = webViewImpl->bestTapNode(targetedEvent);
     ASSERT_TRUE(touchNode);
 
     webViewImpl->enableTapHighlightAtPoint(targetedEvent);
     ASSERT_TRUE(webViewImpl->linkHighlight(0));
 
@@ skipping 33 matching lines @@
     IntRect boundingBox(touchEvent.x - touchEvent.data.tap.width / 2, touchEvent.y - touchEvent.data.tap.height / 2, touchEvent.data.tap.width, touchEvent.data.tap.height);
     findGoodTouchTargets(boundingBox, webViewImpl->mainFrameImpl()->frame(), goodTargets, highlightNodes);
 
     webViewImpl->enableTapHighlights(highlightNodes);
     EXPECT_EQ(2U, webViewImpl->numLinkHighlights());
 
     Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
 }
 
 } // namespace blink