Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1723)

Unified Diff: runtime/observatory/lib/src/app/application.dart

Issue 1403883002: -Fix display of megamorphic miss function. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/application.dart
diff --git a/runtime/observatory/lib/src/app/application.dart b/runtime/observatory/lib/src/app/application.dart
index 80e188db9c8a4b4997fe4a7844bac4b0e0723a51..e4c9d6fa748e4150e0b809992dbb0f8c6eda6985 100644
--- a/runtime/observatory/lib/src/app/application.dart
+++ b/runtime/observatory/lib/src/app/application.dart
@@ -224,6 +224,12 @@ class ObservatoryApplication extends Observable {
}
void handleException(e, st) {
+ if (e is ServerRpcException) {
+ if (e.code == ServerRpcException.kFeatureDisabled) return;
+ if (e.code == ServerRpcException.kVMMustBePaused) return;
+ if (e.code == ServerRpcException.kCannotAddBreakpoint) return;
Cutch 2015/10/13 16:23:14 Maybe log at a fine grained level that we dropped
rmacnak 2015/10/13 17:26:33 Done.
+ }
+
// TODO(turnidge): Report this failure via analytics.
Logger.root.warning('Caught exception: ${e}\n${st}');
notifications.add(new Notification.fromException(e, st));

Powered by Google App Engine
This is Rietveld 408576698