Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 1403853002: Devtools: DOM inspection follows inspect cursor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
index 73b6698bf2df9797e866cba6b9d87bb81a56e46c..5d399ba60f9ed4715514767305d57f469517a799 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
@@ -614,6 +614,19 @@ WebInspector.ElementsTreeOutline.prototype = {
},
/**
+ * @param {?WebInspector.DOMNode} node
+ */
+ highlightNode: function(node)
+ {
+ var treeElement = null;
+ if (node) {
+ treeElement = this.createTreeElementFor(node);
+ treeElement.reveal();
+ }
+ this._setHoverEffect(treeElement);
+ },
+
+ /**
* @return {?TreeElement}
*/
_treeElementFromEvent: function(event)
@@ -723,10 +736,12 @@ WebInspector.ElementsTreeOutline.prototype = {
element.select();
},
- _onmousemove: function(event)
+ /**
+ * @param {?TreeElement} treeElement
+ */
+ _setHoverEffect: function (treeElement)
{
- var element = this._treeElementFromEvent(event);
- if (element && this._previousHoveredElement === element)
+ if (this._previousHoveredElement === treeElement)
return;
if (this._previousHoveredElement) {
@@ -734,10 +749,19 @@ WebInspector.ElementsTreeOutline.prototype = {
delete this._previousHoveredElement;
}
- if (element) {
- element.hovered = true;
- this._previousHoveredElement = element;
+ if (treeElement) {
+ treeElement.hovered = true;
+ this._previousHoveredElement = treeElement;
}
+ },
+
+ _onmousemove: function(event)
+ {
+ var element = this._treeElementFromEvent(event);
+ if (element && this._previousHoveredElement === element)
+ return;
+
+ this._setHoverEffect(element);
if (element instanceof WebInspector.ElementsTreeElement) {
this._domModel.highlightDOMNodeWithConfig(element.node().id, { mode: "all", showInfo: !WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(event) });
@@ -750,11 +774,7 @@ WebInspector.ElementsTreeOutline.prototype = {
_onmouseleave: function(event)
{
- if (this._previousHoveredElement) {
- this._previousHoveredElement.hovered = false;
- delete this._previousHoveredElement;
- }
-
+ this._setHoverEffect(null);
WebInspector.DOMModel.hideDOMNodeHighlight();
},

Powered by Google App Engine
This is Rietveld 408576698